msabramo / requests-unixsocket

Use requests to talk HTTP via a UNIX domain socket
Apache License 2.0
207 stars 29 forks source link

Use an http:// scheme for unix sockets #25

Closed graingert closed 7 years ago

graingert commented 7 years ago

all http+unix:// URIs should now use: http://unixsocket.requests-unixsocket.github.io/ instead

cyberb commented 7 years ago

Am i right that: http+unix://%2Ftmp%2Fprofilesvc.sock/path/to/page Becomes: http://unixsocket.requests-unixsocket.github.io/ %2Ftmp%2Fprofilesvc.sock/path/to/page

msabramo commented 7 years ago

Sorry for taking a long time to respond here. Why did you want to change this? I'm guessing it's because of the bug in requests that was fixed?

My inclination is to close this, unless there is still some good reason. If I were to change the syntax of the URLs, I prefer to change it to something that doesn't require the ugly URL encoding (see https://github.com/msabramo/httpie-unixsocket/issues/8).