search

msakai / data-interval

Interval datatype, interval arithmetic, and interval-based containers for Haskell
Other
21 stars 9 forks source link

Interval relations #18

Closed marcosh closed 4 years ago

marcosh commented 4 years ago

closes #17

marcosh commented 4 years ago

@Bodigrim thanks for the review, should be fine now

marcosh commented 4 years ago

@Bodigrim sorry to bother you, but I just fear you missed my last message saying that the PR should be complete now

Bodigrim commented 4 years ago

I did, I'm terribly sorry! Do not hesitate to ping me, if I'm unresponsive.

Overall looks good. Could you please move Data.IntervalRelation.relate to Data.Interval and implement a similar function for Data.IntegerInterval?

marcosh commented 4 years ago

don't worry.

sure, next week I'll look into it

On Sat, 30 May 2020 at 16:54, Bodigrim notifications@github.com wrote:

I did, I'm terribly sorry! Do not hesitate to ping me, if I'm unresponsive.

Overall looks good. Could you please move Data.IntervalRelation.relate to Data.Interval and implement a similar function for Data.IntegerInterval?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/msakai/data-interval/pull/18#issuecomment-636341613, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUFQBGLN7UAITVSMRRBOYLRUEM2ZANCNFSM4M4OSKWQ .

-- Marco Perone

@marcoshuttle https://twitter.com/marcoshuttle https://github.com/marcosh http://marcosh.github.io/

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.8%) to 90.568% when pulling fa5997e13cad7e1abc4ac5e77e0d2f93d3abdf4f on marcosh:interval-relations into 0e877ce2552ed800520d8b6ff7060880cc666d5f on msakai:master.

marcosh commented 4 years ago

@Bodigrim I completed the things you mentioned

marcosh commented 4 years ago

@Bodigrim done, sorry for those silly things

Bodigrim commented 4 years ago

Merged. Thanks for your efforts!

marcosh commented 4 years ago

Thank you! I had fun doing this

On Wed, 3 Jun 2020, 19:50 Bodigrim, notifications@github.com wrote:

Merged. Thanks for your efforts!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/msakai/data-interval/pull/18#issuecomment-638358368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUFQBBQVIGR3SVMJG3WB53RU2ENJANCNFSM4M4OSKWQ .