msandrini / achiever

A tool built to achieve... wrapper over the old "Achievo" legacy system, transforming the old php+html return into a modern one-page app in React with GraphQL for the API.
MIT License
1 stars 2 forks source link

An in-range update of tough-cookie is breaking the build 🚨 #136

Open greenkeeper[bot] opened 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency tough-cookie was updated from 2.4.3 to 2.5.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

tough-cookie is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **continuous-integration/appveyor/branch:** Waiting for AppVeyor build to complete ([Details](https://ci.appveyor.com/project/msandrini/achiever/builds/20572828)). - ❌ **ci/circleci:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/msandrini/achiever/407?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).

Commits

The new version differs by 18 commits.

  • 7c1fdf1 2.5.0
  • 9ff4ba5 Qualify the store.removeAllCookies documentation
  • 1855bf3 Additional documentation for removeAllCookies
  • 5cc9bd2 Extract tests, cover multiple error path
  • 28f0808 Only call removeAllCookies if actually implemented
  • 62802ef remove all cookies from cookie jar at once (#115)
  • 8783d46 Remove left-over mention of MPL from README
  • 8302ebc Merge pull request #121 from salesforce/punycode-2.1
  • d6ea115 Merge pull request #120 from salesforce/no-package-lock
  • b897b49 Merge pull request #119 from salesforce/inline-version
  • 31ad267 Upgrade to punycode 2.1
  • 550f951 Purposefully don't lock dependencies
  • 3d8570c 2.4.4-1
  • 4cbd182 Merge pull request #118 from salesforce/deps-2018jul30
  • 55a41c1 inline package version using genversion

There are 18 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 2.4.3 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.