search

msandrini / achiever

A tool built to achieve... wrapper over the old "Achievo" legacy system, transforming the old php+html return into a modern one-page app in React with GraphQL for the API.
MIT License
1 stars 2 forks source link

Different ways of passing data on project and activity #61

Closed henriquefacioli closed 6 years ago

henriquefacioli commented 6 years ago

At Edit.jsx, while onSetActivity expects the raw value (id) from the activity, onSetProjectPhase expects an object {id: id}. Is there a reason? If not, should we standardize then both?

msandrini commented 6 years ago

The answers are, respectively, no and yes :)

msandrini commented 6 years ago

In my view, for this case there is no reason to send an object like { id: 0 }, it would only make sense if we were to send other things together within this object.

henriquefacioli commented 6 years ago

64