msanger / flyback

Automatically exported from code.google.com/p/flyback
0 stars 0 forks source link

exclude patterns not working #30

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. include /home/[user] in include list
2. run a backup
3. watch the exclude list be ignored :-(

The default exclude patterns like "/**.thumbnails/" doesnt work.

These should be enforced.

I am using .4 on ubuntu gutsy

Original issue reported on code.google.com by nightsha...@gmail.com on 4 Dec 2007 at 11:47

GoogleCodeExporter commented 9 years ago
I would like to have at GUI an option to choose what to exclude, with this ones 
from
default.

Original comment by goth...@gmail.com on 28 Jan 2008 at 9:26

GoogleCodeExporter commented 9 years ago
Agree with nightshade427; excludes not working on ubuntu.

Original comment by paul.cam...@gmail.com on 4 Feb 2008 at 10:20

GoogleCodeExporter commented 9 years ago
I migth find the problem:
the rsync command line produced by flyback is something like

nice -n19 rsync -av --delete --one-file-system --exclude="/**/.Trash/" [...]
'/home/it7002/' '/backup/test/flyback/20080213_091942.backup/home/it7002/'

and the rsync's transfer-root directory (as from rsync's man page) is 
'/home/it7002'.

The exclude patterns are always relative to the transfer-root directory, so the
"absolute" exclude pattern for .Trash directory become '/home/it7002/**/.Trash/'
which doesn't match with '/home/it7002/.Trash/'.

If the source and destination paths are (check the trailing slash)

'/home/it7002' '/backup/test/flyback/20080213_091942.backup/home'

then
1) the rsync's transfer-root directory will be '/home';
2) the "absolute" exclude pattern will be '/home/**/.Trash/', which matches with
'/home/it7002/.Trash/';

I've attached a patch file that solves for me.
Another possible solution is changing the default exclude patterns from 
'/**/.Trash/'
to '/**.Trash/'.

Original comment by a.morgan...@gmail.com on 13 Feb 2008 at 9:55

Attachments:

GoogleCodeExporter commented 9 years ago
thanks for the rsync info.  i fixed this by making the default excludes relative
instead of absolute.

Original comment by pub...@kered.org on 5 Dec 2008 at 6:41