search

msantos / pkt

Erlang network protocol library
http://blog.listincomprehension.com/search/label/epcap
BSD 3-Clause "New" or "Revised" License
150 stars 44 forks source link

Detection of the IEEE 802.3 ethernet type and LLC codec #11

Closed ates closed 10 years ago

ates commented 10 years ago

Please review the dev branch, it's adds detection of the IEEE 802.3 ethernet type and Logical-Link Control codec.

Detection is based on the length value of the ethernet frame, in case of IEEE 802.3 ethernet it's should less than 1500.

@msantos, why do we need the ETH_P_ALL in the include/pkt_ether.hrl?

msantos commented 10 years ago

Looks good, please merge!

About ETH_P_ALL: good question. Seems like I added it so the constant would be defined somewhere for procket. It's not used anymore, so ETH_P_ALL can be removed.

ates commented 10 years ago

Merged