add 802.1x - Githubissues

alexshavelev commented 8 years ago

Hi, please have a look. I tried add 802.1x as described in issue, but not sure it works right. Please check when you have time

msantos commented 8 years ago

Hey @alexshavelev ! Thanks so much for the patch! I will have to try to understand the protocol spec so it might take me a few days but it looks good. Some quick comments:

can you rebase the patch into one commit? If not, don't worry about it. I'll do it before we merge.
do we need to add a copy of rebar3 to the repo?
please leave yourself as the author but do you mind if the copyright is assigned to me? I'm planning on switching to the ISC license and it'll make it easier
add some tests: you can either include an example of a packet in the test or use a pcap file (see the sctp tests). The tests should include encoding a packet from an erlang term

Thanks again Alexander!

alexshavelev commented 8 years ago

Hey!

1) ok, i will make it today or tommorow 2) no, we needn't. firstly i have some troubles without having it. but i solved it updating erlang.mk (i use it in my projects) 3) of course, no problems 4) will try to make it till the end of the week

alexshavelev commented 8 years ago

i made some more tests and seems it works not as expected, so i close PR. will open new when will have more free time and fix

msantos / pkt

add 802.1x #35