msantos / pkt

Erlang network protocol library
http://blog.listincomprehension.com/search/label/epcap
BSD 3-Clause "New" or "Revised" License
150 stars 44 forks source link

Update README, and add copyrights in pkt_lldp and pkt_mpls #38

Closed shun159 closed 8 years ago

shun159 commented 8 years ago

hello @msantos,

I updated #exports section to add #lldp{} and #mpls{}, and add copyrights to pkt_lldp and pkt_mpls. please review.

regards.

msantos commented 8 years ago

Thanks! BTW, feel free to push your changes directly to the repo.

Small issue with the mpls test I missed:

  undefined
    %% Unknown error: {abort,
                   {bad_test,
                       {ether,
                           <<194,5,99,77,0,0>>,
                           <<194,3,99,62,0,0>>,
                           34887,0}}}

Looks like the tests just need to be wrapped in ?_assertMatch().

shun159 commented 8 years ago

@msantos thank you for merge.

Small issue with the mpls test I missed:

Oh! sorry, i will fix it...

Thanks! BTW, feel free to push your changes directly to the repo.

ok, thanks.

regards.