search

msantos / pkt

Erlang network protocol library
http://blog.listincomprehension.com/search/label/epcap
BSD 3-Clause "New" or "Revised" License
150 stars 44 forks source link

Update pkt_icmp6.erl #45

Closed alexshavelev closed 7 years ago

alexshavelev commented 7 years ago

according to RFC - https://tools.ietf.org/html/rfc4861#section-4.4 we put Target Address, so think it should be in daddr rather sassr

msantos commented 7 years ago

I guess this could either way :) We should do whatever is more intuitve.

I think the reason for (re-)using the source address field is because the target address is the link layer address of the node sending the advertisement:

Target link-layer address
                     The link-layer address for the target, i.e., the
                     sender of the advertisement.
alexshavelev commented 7 years ago

huh, ok for me more intuitive was to put in daddr