search

msaraiva / atom-elixir

An Atom package for Elixir
MIT License
408 stars 27 forks source link

Port to JavaScript (ES6) #73

Open jayjun opened 7 years ago

jayjun commented 7 years ago

There appears to be an unofficial move to JavaScript, especially for new development. I think it’s a good move, for aspiring contributors and future-proofing.

In this pull request, I refactored (by hand) all CoffeeScript to JavaScript, and CSON to JSON.

Since the tests were not working to begin with, I can’t say for certain that nothing broke. However, I have used it in my daily work and it’s been 100% the same.

Personally, I never want to learn CoffeeScript well. So, this is really my first step to future contributions!

msaraiva commented 7 years ago

@jayjun this is fantastic! Getting rid of CoffeeScript is definitely wanted. I'll start using your branch right away so I can use/test it for a couple of days and then I'll merge it.

Thanks for your contribution!

jayjun commented 7 years ago

@msaraiva Cool, my fork was deleted. Anyway, it’s all back up on GitHub. Let me know if you need a new pull request.

NuckChorris commented 6 years ago

If you merge this I'd love to help out, but I'm just dreadful at CoffeeScript!