msarhan / ummalqura-calendar

Implementation of java.util.Calendar for the Umm Al-Qura calendar system.
MIT License
154 stars 51 forks source link

Invalid Hijrah day of month: 30 #26

Closed anastr closed 3 years ago

anastr commented 3 years ago

This simple code throw DateTimeException exception:

val dateFormat = SimpleDateFormat("dd/MM/yyyy", Locale.US)
dateFormat.calendar = UmmalquraCalendar()

val calendar = UmmalquraCalendar()
calendar.time = dateFormat.parse("30/02/1442")!!

It says Invalid Hijrah day of month: 30 but month 4 does have 30 days!

Any help?

Sabboo commented 3 years ago

I am facing the same issue with v2.0.1

com.github.msarhan.ummalqura.calendar.DateTimeException: Invalid Hijrah day of month: 31 at com.github.msarhan.ummalqura.calendar.HijrahChronology.getEpochDay(HijrahChronology.java:255) at com.github.msarhan.ummalqura.calendar.HijrahChronology.toGregorian(HijrahChronology.java:697) at com.github.msarhan.ummalqura.calendar.UmmalquraCalendar.set(UmmalquraCalendar.java:250) at net.alhazmy13.hijridatepicker.date.hijri.HijriDatePickerDialog.getEndDate(HijriDatePickerDialog.java:1028) at net.alhazmy13.hijridatepicker.date.hijri.MonthAdapter.getCount(MonthAdapter.java:146) at android.widget.ListView.setAdapter(ListView.java:581) at net.alhazmy13.hijridatepicker.date.hijri.DayPickerView.refreshAdapter(DayPickerView.java:142) at net.alhazmy13.hijridatepicker.date.hijri.DayPickerView.setController(DayPickerView.java:114) at net.alhazmy13.hijridatepicker.date.hijri.DayPickerView.(DayPickerView.java:105) at net.alhazmy13.hijridatepicker.date.hijri.SimpleDayPickerView.(SimpleDayPickerView.java:32) at net.alhazmy13.hijridatepicker.date.hijri.HijriDatePickerDialog.onCreateView(HijriDatePickerDialog.java:340) at androidx.fragment.app.Fragment.performCreateView(Fragment.java:2950) at androidx.fragment.app.DialogFragment.performCreateView(DialogFragment.java:482) at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:515) at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282) at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2177) at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2088) at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1990) at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:524)

Can we have support on this ?