msarhan / ummalqura-calendar

Implementation of java.util.Calendar for the Umm Al-Qura calendar system.
MIT License
154 stars 51 forks source link

An issue with Proguard #8

Closed meMuhammadkamal closed 6 years ago

meMuhammadkamal commented 8 years ago

I get this warning while generating signed Apk: and i did add the following in the rules:

-keep class  com.github.msarhan.ummalqura.calendar.**{ *; }
-keep interface com.github.msarhan.ummalqura.calendar.**{ *; }
Warning:com.github.msarhan.ummalqura.calendar.UmmalquraDateFormatSymbols: can't find referenced class java.util.Locale$Category
Warning:com.github.msarhan.ummalqura.calendar.UmmalquraDateFormatSymbols: can't find referenced method 'java.util.Locale getDefault(java.util.Locale$Category)' in library class java.util.Locale
Warning:com.github.msarhan.ummalqura.calendar.UmmalquraDateFormatSymbols: can't find referenced class java.util.Locale$Category
Note: android.support.v4.media.IMediaBrowserServiceCallbacksAdapterApi21: can't find dynamically referenced class android.service.media.IMediaBrowserServiceCallbacks
Note: android.support.v4.media.IMediaBrowserServiceCallbacksAdapterApi21: can't find dynamically referenced class android.content.pm.ParceledListSlice
Note: android.support.v4.media.IMediaBrowserServiceCallbacksAdapterApi21$Stub: can't find dynamically referenced class android.service.media.IMediaBrowserServiceCallbacks$Stub
Note: android.support.v4.media.ParceledListSliceAdapterApi21: can't find dynamically referenced class android.content.pm.ParceledListSlice
Note: android.support.v4.text.ICUCompatApi23: can't find dynamically referenced class libcore.icu.ICU
Note: android.support.v4.text.ICUCompatIcs: can't find dynamically referenced class libcore.icu.ICU
Note: android.support.v7.widget.DrawableUtils: can't find dynamically referenced class android.graphics.Insets
Note: android.support.v4.app.NotificationCompatJellybean accesses a declared field 'icon' dynamicallyk
flibbertigibbet commented 7 years ago

The project references Locale.Category here.

It looks like Locale.Category was only added in API 24 and so will not be supported in anything other than the developer preview.

API level 24 also adds support for Islamic calendars, and so this project will not be necessary in the upcoming releases.

adiga-maf commented 7 years ago

use this and the warning will disappear: -dontwarn com.github.msarhan.ummalqura.calendar.**