search

msavva / WebSceneStudio

1 stars 3 forks source link

Cannot Overload Built-In Key Combinations #38

Closed gilbo closed 12 years ago

gilbo commented 12 years ago

I've been trying to figure out how to do this via event.preventDefault(), which is what we've had in the code. Because I've now remapped copy/paste/etc. to use the command modifier key on mac, I'm now running into conflicts.

Bug: calling preventDefault() on a keydown event will suppress the associated keyup event. But we absolutely NEED the keyup event. And there's no way to suppress the browser's "default action" without calling preventDefault().

For more details you can see the W3 spec: http://www.w3.org/TR/2012/WD-DOM-Level-3-Events-20120906/#event-flow-default-cancel I'm thinking the best thing to do would be to just give up on overriding default key shortcuts and use a more web-y convention.

msavva commented 12 years ago

I would agree with migrating to non-reserved keyboard shortcut convention since that seems it would save us from further headaches. Provided we display the keyboard shortcuts in the Toolbar icons and/or tooltips this change should not really impact interface usability.

gilbo commented 12 years ago

Remapped to plain keys 32a46c435400680b23965169b438565f31f60523