Add Rating Stars On Now Playing Screen

[GoogleCodeExporter]

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by pepijn.k...@gmail.com on 19 Dec 2010 at 10:55

[GoogleCodeExporter]

Hmm, I can't pair my droid to iTunes atm (Samsungs Galaxy S i9000).

Original comment by pepijn.k...@gmail.com on 28 Dec 2010 at 11:11

[GoogleCodeExporter]

Download the latest 2.0.7 release from the Android Market or do an SVN UPDATE.  
I just fixed some bugs with pairing with iTunes.  This could also mean you have 
some sort of firewall issue.

Original comment by mellowaredev on 28 Dec 2010 at 11:12

[GoogleCodeExporter]

OK, done that. Are you testing iTunes 10.1.1.4 - since I'm not able to connect 
phone or emulator manually or automatically.

Original comment by pepijn.k...@gmail.com on 28 Dec 2010 at 11:20

[GoogleCodeExporter]

Yes that is the exact iTunes version I am running.

Make sure you can communicate on TCP ports 3689 and 1024 and UDP port 5353 in 
your firewalls and such.

Also don't be running MonkeyTunes at the same time..both iTunes and MonkeyTunes 
both can't have port 3689 so only be running iTunes when you try this.

Original comment by mellowaredev on 28 Dec 2010 at 11:22

[GoogleCodeExporter]

Ah got it working on the device now (had to do manual add, and iTunes clean 
history)

Original comment by pepijn.k...@gmail.com on 28 Dec 2010 at 11:26

[GoogleCodeExporter]

Almost fixed but now I can't verify it on MM because it doesn't pair.

Original comment by pepijn.k...@gmail.com on 28 Dec 2010 at 11:58

[GoogleCodeExporter]

Fix:

### Eclipse Workspace Patch 1.0
#P TunesRemote
Index: src/org/tunesremote/daap/Status.java
===================================================================
--- src/org/tunesremote/daap/Status.java    (revision 44)
+++ src/org/tunesremote/daap/Status.java    (working copy)
@@ -338,14 +338,18 @@
                try {
                    Response resp = RequestHelper.requestParsed(
                            String.format(
-                                   "%s/databases/%d/items?session-id=%s&meta=dacp.userrating,daap.userrat
ing&type=music&query='dmap.itemid:%d'",
+                                   "%s/databases/%d/items?session-id=%s&meta=daap.songuserrating&type=mus
ic&query='dmap.itemid:%d'",
                                    session.getRequestBase(),
                                    session.databaseId, session.sessionId,
                                    songId), false);

                    if (update != null) {
-                       rating = resp.getNested("apso").getNested("mlcl")
-                               .getNested("mlit").getNumberLong("asur");
+                       // 2 different responses possible!              
+                       Response entry = resp.getNested("adbs"); // iTunes style
+                       if (entry == null) {
+                           entry = resp.getNested("apso"); // MonkeyTunes style
+                       }
+                       rating = 
entry.getNested("mlcl").getNested("mlit").getNumberLong("asur");                        
                        update.sendEmptyMessage(UPDATE_RATING);
                    }

Original comment by pepijn.k...@gmail.com on 29 Dec 2010 at 12:13

[GoogleCodeExporter]

Smoketested with MonkeyTunes and iTunes now...

Original comment by pepijn.k...@gmail.com on 29 Dec 2010 at 12:14

[GoogleCodeExporter]

Excellent.  I will load this patch and upload a new version to the Market.

Original comment by mellowaredev on 29 Dec 2010 at 5:59

[GoogleCodeExporter]

OK this patch has been applied and version 2.0.8 is on the Market now.

Original comment by mellowaredev on 29 Dec 2010 at 6:05

• Changed state: Fixed

[GoogleCodeExporter]

Tested with iTunes on Mac. Stars show, but changes are not reflected on iTunes 
in real time. Going to settings and back to main screen, it resets any prior 
change to the rating. 

Original comment by rayner...@gmail.com on 29 Dec 2010 at 9:29

[GoogleCodeExporter]

I am re-opening this defect as another user reported this with iTunes also.

Original comment by mellowaredev on 25 Jan 2011 at 7:56

• Changed state: Accepted

[GoogleCodeExporter]

So you don't see the stars appear in iTunes? hmmm, wonder if thats not an 
iTunes issue...Does the original apple remote updates stars while in library 
view?

Original comment by pepijn.k...@gmail.com on 25 Jan 2011 at 8:00

[GoogleCodeExporter]

I don't think the Apple Remote does but since it is just a http call the iTunes 
server should respect it no matter what mode the client or server is in.  It is 
simply a call to update rating of a specific track.  But that is just a 
hypothesis....

Original comment by mellowaredev on 25 Jan 2011 at 8:13

[GoogleCodeExporter]

Adding dandroid to debug the why the rating stars don't work on iTunes but do 
work in MonkeyTunes...

Original comment by mellowaredev on 25 Mar 2011 at 12:24

[GoogleCodeExporter]

Original comment by mellowaredev on 25 Mar 2011 at 1:28

[GoogleCodeExporter]

I have been working on a Java library to do basically the same thing as 
tunesremote-plus and I managed to get this working in iTunes.  iTunes will show 
the update immediately.  I was getting a 404 response from iTunes unless I 
specified the itemid.

/ctrl-int/1/setproperty?dacp.userrating=%d&song-spec='dmap.itemid:%d'&session-id
=%s'

Original comment by fang...@gmail.com on 28 Mar 2011 at 8:37

[GoogleCodeExporter]

Hi fanguad,
Thats interesting! Please feel free to submit a patch for it.
cheers,
pepijn

Original comment by pepijn.k...@gmail.com on 28 Mar 2011 at 8:47

[GoogleCodeExporter]

OK so this hopefully should be easy to patch.  I will look at it tomorrow.

Original comment by mellowaredev on 28 Mar 2011 at 10:28

[GoogleCodeExporter]

OK I just checked in the fix for this into SVN.

Original comment by mellowaredev on 29 Mar 2011 at 12:37

• Changed state: Fixed