Avoid using global Buffer

[mscdex]

Why?

[jimmywarting]

trying to assume that it exist globally is problematic for bundlers. it needs to scan the code if one is using globalThis.buffer and needs to decide if it have to polyfill it or not.

• linters such as xo forbids global buffer
• using global buffer/process is an anti-patern according to https://github.com/nodejs/modules/issues/235 and https://github.com/nodejs/node/pull/26334
• NodeJS own docs recommend importing it: https://nodejs.org/api/buffer.html#buffer_buffer instead of depending on global.Buffer

  While the Buffer class is available within the global scope, it is still recommended to explicitly reference it via an import or require statement.

• it was once attempted to warn/deprecate access to globalThis.buffer by assigning it a deprecation warning getter function.

my own code can detect this kinds of patterns where ppl try to use globalThis.buffer and yours is one of them

[mscdex]

As far as linting goes, this project uses eslint and not xo. Attempting to support arbitrary linters and linting configurations doesn't make sense.

Regarding the aforementioned links and notes about deprecating global Buffer, that was only for ES modules. busboy is a CJS module.

[jimmywarting]

In any case i think you should attempt to only use Uint8Array instead of the overhead Buffer if at all possible.

[mscdex]

In any case i think you should attempt to only use Uint8Array instead of the overhead Buffer if at all possible.

That's not very feasible considering:

• This module utilizes Buffer-specific functionality
• Node.js users are more accustomed to dealing with Buffers at this point
• Working around the limitations of Uint8Array would not only require adding more code to polyfill functionality but it could also easily result in lower performance