Build fails with node ^12.0.0

mscdex / mmmagic

An async libmagic binding for node.js for detecting content types by data inspection

MIT License

619 stars 50 forks source link

Build fails with node ^12.0.0 #139

Closed tiger31 closed 5 years ago

mscdex commented 5 years ago

Fixed in 78decce5ff93db8f713a5bb0041ce31ef705a1b9.

codingride commented 5 years ago

One more question regarding this issue if I may. When I clone or download the latest repo from github it compiles without any issues. But when I include it in my project dependencies and install it, it gives me "failed with exit code: 1" error. So I was wondering if the latest repo was pushed or updated on npm servers?

mscdex commented 5 years ago

There isn't a published version on npm yet, if that's what you're asking.

codingride commented 5 years ago

Thank you for your answer. Is it going to be published on npm soon, if I can ask?