search

mscdex / node-ftp

An FTP client module for node.js
MIT License
1.13k stars 244 forks source link

store: call callback on socket error. #105

Closed bdegreve-am closed 9 years ago

bdegreve-am commented 9 years ago

Hello, When a socket error happens during an STOR or APPE, this error doesn't seem to propagate to the callback passed to put() or append(). I believe a single call to cb should be added in the socket error handler. At least, it solves the issue I have at hand. Can you verify this? Thanks.

mscdex commented 9 years ago

It should be passing the socket error to the callback if there was one, inside sendStore().

bdegreve-am commented 9 years ago

True. It behaves correctly. Perhaps there was an issue before, but it's gone now.