search

mscdex / node-ftp

An FTP client module for node.js
MIT License
1.13k stars 243 forks source link

MLSD #107

Open morris opened 9 years ago

morris commented 9 years ago

Hi!

First of all, thanks for this great package, it backs the new vinyl-ftp and turns out to be very, very robust.

However, I needed to implement MLSD for better listings (needed seconds). It's just a small derivation from your LIST code, and I thought you might want to include it. It should be trivial to implement MLST, too. I could also work this into a pull request if you wanted.

https://github.com/morris/vinyl-ftp/blob/master/mlsd.js

mscdex commented 9 years ago

I'd be open to a PR adding them as separate methods (and not automagically used for directory listings). Since there is some overlap with the existing dir listing functionality, it would be great to share some of the common code to keep things DRY.

morris commented 9 years ago

Definitely, I also use both MLSD and LIST (as a fallback if MLSD is not supported). Hope I get around to filing the PR one of these days...