mscdex / node-ftp

An FTP client module for node.js
MIT License
1.13k stars 243 forks source link

Consistency in passive socket's variable name #177

Open gbourel opened 7 years ago

gbourel commented 7 years ago

When reading current lib/connection.js implementation ( commit 7dff82f ) I noticed that the passive socket reference is mainly written as _pasvSock but sometimes written _pasvSocket (with the trailing characters 'et' ): Defined at L60 this._pasvSock = undefined; Used as _pasvSocket in both _pasvConnect() L903, _send() L1034 methods. But again written as _pasvSock in _reset() L1053 method.

Did I miss the usage of the two different references with different meaning or may it be a typo ?