search

mscdex / node-ftp

An FTP client module for node.js
MIT License
1.13k stars 246 forks source link

test: use ISO strings for dates #191

Closed targos closed 6 years ago

targos commented 7 years ago

Fixes the tests for Node 8. Ref: https://github.com/nodejs/citgm/issues/466

gibfahn commented 7 years ago

@targos to confirm, this still works with older node versions right?

targos commented 7 years ago

I confirm. Just ran the tests on 0.8, 0.10, 0.12, 4, 6 and 8 ;)

targos commented 7 years ago

ping @mscdex. Could you please check this?

MylesBorins commented 6 years ago

Still seeing failurs on 8.x

ping @mscdex

targos commented 6 years ago

ping

al-k21 commented 6 years ago

Seems like this resolves the issue. Why this has not landed? @targos @mscdex

Can we land this and then we can unskip ftp.

targos commented 6 years ago

I didn't get any answer, so I closed this during a personal PR cleanup. Happy to reopen if it can be merged and released by someone.