search

mscdex / node-ftp

An FTP client module for node.js
MIT License
1.13k stars 244 forks source link

Change to emit `end` and `close` immediately at EOF during download #259

Open std4lqi opened 4 years ago

std4lqi commented 4 years ago

Signed-off-by: Qi Liang liangqi@cn.ibm.com

Change to emit end and close at EOF immediately during download, without waiting for 226 or 250 for RETR. This could close the stream quickly, instead of hanging for 1 or 2 minutes on Node.JS v10 and v12.

std4lqi commented 4 years ago

It's to fix #228 actually.

thingalon commented 4 years ago

I have also run into a similar issue on Node 11 and 12, and can confirm this PR fixes it. Thanks @std4lqi!

jasonwilliams commented 2 years ago

See https://github.com/mscdex/node-ftp/issues/277