REST send before RETR if restart is used. fixes #76

mscdex / node-ftp

An FTP client module for node.js

MIT License

1.13k stars 243 forks source link

Open holymoly opened 10 years ago

holymoly commented 10 years ago

this commit fixes #76

holymoly commented 10 years ago

Don't know why this happend. thought that naming the issue should be enough...

holymoly commented 10 years ago

This ones fixes the issue with the restart command. Would be good if someone check the code.

mscdex commented 10 years ago

Aside from the inline comments, there are a couple of other issues:

The err argument passed to the callback in _send() should be checked (in case REST is not supported on the server) and appropriate action should be taken if err is indeed set.
Code style should match the rest of the source code (mainly spacing here)

holymoly commented 10 years ago

I hope to find some time to change the other things (check Rest support of Server, err Handling and Code Style) on the Weekend.