search

mscdex / node-ncurses

An ncurses binding for node.js
MIT License
386 stars 25 forks source link

Node-gyp rebuild fails on Node.JS 0.12.0 when installing node-ncurses #55

Closed pmcmonagle closed 9 years ago

pmcmonagle commented 9 years ago

Using Node.JS version 0.12.0, npm install ncurses results in a long string of errors:

../src/binding.cc:84:1: error: unknown type name 'uv_poll_t'
../src/binding.cc:667:34: error: unknown type name 'uv_handle_t'
../src/binding.cc:688:37: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
../src/binding.cc:721:39: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?
../src/binding.cc:731:38: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?

etc.

Rolling back to Node.JS 0.10.37 (eg. via NVM) solves the problem.

Using:

mscdex commented 9 years ago

This module hasn't been updated to use nan yet and I don't have the time to do this. There was a PR to add support for this, but nan has changed quite a bit since then and would need a new PR, which I am more than willing to accept.

mscdex commented 9 years ago

Should be fixed with 507638965a.