mscdex / node-xxhash

An xxhash binding for node.js
Other
193 stars 28 forks source link

adapted binding to use nan for cross-version compatibility #6

Closed ceejbot closed 9 years ago

ceejbot commented 10 years ago

This change or something like it is required for the module to work with node 0.11 and therefore 0.12, thanks to V8 API changes.

The Travis 0.11 build is failing for unrelated reasons, I believe. You can use nvm to install 0.11.9 and test by hand.

ceejbot commented 10 years ago

Spoke too soon on Travis: trying again succeeded with 0.11.

ceejbot commented 10 years ago

Ping?

mscdex commented 10 years ago

I appreciate the work you've done here, but I think it's probably going to be best to wait for node core's own abstraction API. AFAIK it's still supposed to land before v0.12. If not, I wonder why node core doesn't just adopt nan now, so that us binding authors don't have to end up going back and changing our code again.

mscdex commented 9 years ago

The master branch has now been nan-ized and also includes the latest xxhash and a stream interface.