search

mscdex / socksv5

SOCKS protocol version 5 server and client implementations for node.js
MIT License
399 stars 121 forks source link

socket.close(); #2

Closed enormouspenguin closed 10 years ago

enormouspenguin commented 10 years ago

Hi, I have been scanning through your code in lib/server.js and came across the line number 39:

socket.close();

I have searched through JS sources from 0.8.27, 0.10.29 and 0.11.13 but I couldn't find where socket.close() was defined. The only one closest to close() was destroy(). I think you could be confused by socket._handle.close() and put the wrong one there. Although, I am not entirely sure because I couldn't search C++ sources (C++ newbie here).

mscdex commented 10 years ago

Fixed in 81e6cda131. Thanks!

enormouspenguin commented 10 years ago

No problem. I am glad to be of any help.