search

mscdex / socksv5

SOCKS protocol version 5 server and client implementations for node.js
MIT License
400 stars 121 forks source link

copy normalizeConnectArgs from node 6 #23

Open lee-elenbaas opened 7 years ago

lee-elenbaas commented 7 years ago

This should fix #22

lee-elenbaas commented 7 years ago

net._normalizeConnectArgs is not longer available on node 7 - so i removed the dependency in it, by placing the implementation inside the library

bitinn commented 7 years ago

@mscdex do you have time to review this PR? This is likely true as we have a few users reporting similar issues.

malexdev commented 7 years ago

👍 , I am also having this issue.

cjnqt commented 7 years ago

Same here - breaks on node >7. The fix looks good!

lee-elenbaas commented 7 years ago

@cjnqt since @mscdex does not seem to be active - feel free to use my fork

cjnqt commented 6 years ago

Ping @mscdex - could you please merge this?