Open Natizyskunk opened 3 years ago
@TheZoker I just revert the old links in the README.md file but also in package.json and node-fs-compat.js only keeping the needed changes to fix the error. Do you think i've to change the links in my package.json to point to my own repo since this is a modification I've made and that has still not been merged ?
@Natizyskunk Thanks for adjusting! No the current way is fine, although I'm not sure, if @mscdex want's to update the version number on his own, when he releases a new update. We have to wait for his feedback 🙂
@TheZoker No problem. Ok then we will wait & see ^^
This repo is more or less deprecated as the protocol implementations are being moved back upstream into ssh2
.
I've just seen that. That's sound great, hopefully you'll add the fix for this bug ^^
I guess what he says is, that the files are now directly located within ssh2
:
https://github.com/mscdex/ssh2/tree/master/lib/protocol
A similar PR is already open in that repo: https://github.com/mscdex/ssh2/pull/1009
Can confirm, that this solves the issue!
@Natizyskunk you should not change the links in the readme files to your own repo