mschack / VCV-Rack-Plugins

Plugins for VCV Rack
MIT License
61 stars 19 forks source link

ARP700 v1.0.1 Won't stop running #91

Open therealkitman opened 5 years ago

therealkitman commented 5 years ago

Having a few issues with ARP700 under rack v1.1.1

  1. If a clock signal is stopped the arp continues to run. Only when I remove the clock cable from clock input does arp stop running.
  2. I can't manually select the 1st pattern with the mouse if I click from a different pattern. But again if I remove the clock cable I get access to the 1st pattern.

Nice to see this module made it to V1 :+1:

mschack commented 5 years ago

thanks I'll look into it

mschack commented 5 years ago

Ok now I recall this. It is a known issue. The ARP multiplies the input clock, i.e. makes it go faster for 16ths, 32nds and 64ths etc. This is done by sampling the input rate and then running an internal clock at the faster rate, doubling, quadrupling it etc. The reason I can't just stop the clock when the external clock stops is that the internal clock sample mechanism can't tell if you have stopped the clock or just slowed it down, so it is just sits waiting for the next clock pulse while the last known rate keeps playing. I have tried to think how to fix this, such as saying well maybe if the clock doesn't come in some arbitrary time period, say 5 seconds, then stop, but that doesn't really help you if you stop the clock and it doesn't actually stop immediately. A solution I have contemplated adding is a "trigger mute" that you can input a gate and it will stop sending the trigger outputs (meanwhile it keeps clocking with the added bonus of not getting out of sync with the rest of the patch). Would this be helpful?

therealkitman commented 5 years ago

Ah, so this is not a bug but a design feature. I'm just doodling/noodling with everything and can work around it by using a signal flow module. And regarding the other issue with selecting patterns, that has gone in v1.0.2. :+1: I'll leave it up to you if you want to pursue a "trigger mute" and happy for you to close this.

I would suggest though that if you do add a 'trigger mute' to also add a 'button' for the reset next to its CV input as well as a CV input for pause.

Many thanks.

mschack commented 5 years ago

Same as the trigger mutes on the Triad2, that button/cv input at the top right of each keyboard which was the latest feature added to it. If you press the button it stops the trigger out but the keyboard keeps playing.

therealkitman commented 5 years ago

Just had a play with Triad2 (very nice). Yes, it's trigger mutes would be the way to go on Arp.

Triad1 - what is the n/o button when it's active?

mschack commented 5 years ago

n/o is note off, so you can turn off the trigger per note. As a space between notes. The v/oct is still active so if there is a note change you may still hear it if your synth has a longer release time in which case it would be more like a legato note.