mschae23 / grind-enchantments

Put enchantments back on a book using a grindstone.
https://legacy.curseforge.com/minecraft/mc-mods/grind-enchantments
GNU Lesser General Public License v3.0
12 stars 13 forks source link

Bug: grinding curses produces generic "enchanted books" #14

Closed MeeniMc closed 3 years ago

MeeniMc commented 3 years ago

When grinding an item with only curses (binding or vanishing) and a book, it produces a generic "enchanted book". The correct behavior is to not produce anything at all, as it is actually impossible to remove a curse from an item.

When the item has a mix of curses and enchants, it first produces a book with all valid enchants, and then goes back to the bug (since the object has now only curses). That may be the intended behavior in that case, or maybe the intended behavior is that it is impossible to create books form cursed objects at all, it's a balance choice.