mschae23 / grind-enchantments

Put enchantments back on a book using a grindstone.
https://legacy.curseforge.com/minecraft/mc-mods/grind-enchantments
GNU Lesser General Public License v3.0
12 stars 13 forks source link

Updated to 1.18 #17

Closed ClaudeGontier closed 2 years ago

Fourmisain commented 2 years ago

Just some feedback:

Since there were no breaking changes between 1.17 and 1.18 (meaning the 1.17 version runs on 1.18 too), I'd personally still target Minecraft >=1.17- and Java 16, leaving the build.yml at version 17. The mixin compatibilityLevel should also be set to JAVA_16 or JAVA_17.

In Loom 0.10 https://github.com/ClaudeGontier/grind-enchantments/blob/32b36eeb98b031509d93df77f054de0086443f5b/build.gradle#L54-L59 should be replaced by

mavenJava(MavenPublication) {
    from components.java
}

and the it.options.encoding = "UTF-8" is not needed anymore (it's part of Loom now).

mschae23 commented 2 years ago

Thank you!