search

mschae23 / grind-enchantments

Put enchantments back on a book using a grindstone.
https://legacy.curseforge.com/minecraft/mc-mods/grind-enchantments
GNU Lesser General Public License v3.0
12 stars 13 forks source link

3.0b1 produces 'random enchantment book' #39

Closed MeeniMc closed 1 year ago

MeeniMc commented 1 year ago

Versions

1.19.3/3.0b1

Problem description

When a non-enchanted item is put in the grinder with a stack of books, the following 2 defects are observed

  1. The produce slot proposes to create a "random enchantment book", and such book can be obtained.
  2. A full stack of books is consumed when producing the "random enchantment book" if such a stack was put in the grinder.

Expected

  1. When a non-enchanted item is in the grinder, adding a book should have no produce
  2. a single book should always be consumed

v2.0

This bug is not present in v2 of the mod.

mschae23 commented 1 year ago

I can only investigate this later today, but it's interesting that this only happens in 3.0, as I believe I only changed the way configs work there.

What is a "random enchantment book"? Is it one with no enchantments on it, or an actual random one?

mschae23 commented 1 year ago

I can't reproduce this with version 3.0.0-beta.1 on 1.19.3. When putting an unenchanted item and any number of books into the grindstone, nothing happens for me.

Could this be a mod compatibility issue? Do you have any other mods installed that modify the grindstone?

MeeniMc commented 1 year ago

It IS a mod compatibility issue!

EMI Loot causes this. It's probably on their side too, since I had a similar issue with Lootr in the past, should have remembered.

MeeniMc commented 1 year ago

Issue is with other mod

mschae23 commented 1 year ago

Alright. Sorry for not looking into this yet. I was meaning to do that, but didn't have time so far.