mschae23 / grind-enchantments

Put enchantments back on a book using a grindstone.
https://legacy.curseforge.com/minecraft/mc-mods/grind-enchantments
GNU Lesser General Public License v3.0
12 stars 13 forks source link

[Request] Make enchanted items in enchanting table non-"grindable" #56

Open Anonyku05 opened 2 months ago

Anonyku05 commented 2 months ago

The mod itself is good, but one thing kinda bothers me (it's not your fault but how Minecraft works): it's the fact that I can enchant any tool infinitely and get all the enchantments from it. For example, I can enchant a pickaxe non-stop and get infinite enchanting books, which kind of breaks the system in Minecraft and makes villagers somewhat useless for enchanting (except for mending). So, I wanted to know if it's possible to prevent a tool from getting its enchantments if it has already been enchanted on an enchanting table, or if that's simply impossible to determine.

Thanks in advance.

mschae23 commented 2 months ago

[...] makes villagers somewhat useless for enchanting

Well, they're not supposed to be the main source of enchantments, that's the enchanting table :)

But yes, this is not detectable in vanilla. The item stack only stores the enchantments on it, not where they came from. This is something that may be possible to fix, though – an option that disallows using the enchanting table on items that have previously been disenchanted, for example?

Anonyku05 commented 1 month ago

I like the idea, making it completly unenchantable once it has been disenchanted just once (still allowing for the other enchants to be removed if thbere are many)

chonkyman commented 1 month ago

I disagree, I like having the ability to do this. It still requires xp, you don't get enough back when you disenchant to where it becomes an infinite loop.