Closed niclan closed 10 years ago
Second patch is to drop from gid 0 because the app that's no longer root needs the right group to be able to write to some files/pipes/socets (rrdcached socket in our case).
I've patched up your pull request (never use tabs for indentation on a OSS project that uses spaces, wars have been started for less :) and merged it:
https://github.com/mschilli/app-daemon/commit/b7c5a88f089625effc71af546023f8432aaf2947
It only seems to contain the group feature you mentioned, not the other one, so if you want that to be included as well, please submit a new pull request for that.
Thanks for your contribution!
Hi,
I work mostly alone on stuff and this is the emacs default. I've now inserted a line in my emacs setup to prevent the tab cockup from recurring. I have read about the tab vs. spaces thing but it never really came up before. Sorry.
The thing I meant to send in the first changeset is there:
around line 188.
} elsif ($as_user) {
id_switch();
}
I now notice that that should read
} elsif ($as_user or $as_group) {
id_switch();
}
but the if is also kind of redundant because $as_user and $as_group is always set?
What version will this be?
Den 27. april 2014 07:26, skrev Mike Schilli:
I've patched up your pull request (never use tabs for indentation on a OSS project that uses spaces, wars have been started for less :) and merged it:
https://github.com/mschilli/app-daemon/commit/b7c5a88f089625effc71af546023f8432aaf2947 It only seems to contain the group feature you mentioned, not the other one, so if you want that to be included as well, please submit a new pull request for that.
Thanks for your contribution!
— Reply to this email directly or view it on GitHub https://github.com/mschilli/app-daemon/pull/4#issuecomment-41488798.
Nicolai Langfeldt - OSS Arkitekt og koder Broad|Net - Norges ledende leverandør av fiber til bedrifter og operatører. Tenk grønt: Trenger du virkelig å skrive ut denne eposten?
... otherwise the application runs as root when you asked to to remain in the foreground for debugging.