mschilli / log4perl

Log4j Implementation For Perl
http://log4perl.com
Other
116 stars 66 forks source link

Log::Log4perl::Catalyst has no version #105

Closed eserte closed 3 years ago

eserte commented 3 years ago

At least CPAN.pm thinks that Log::Log4perl::Catalyst has no version:

cpan[1]> m Log::Log4perl::Catalyst
...
Module id = Log::Log4perl::Catalyst
    CPAN_USERID  MSCHILLI (Michael Schilli <m@perlmeister.com>)
    CPAN_VERSION undef
    CPAN_FILE    E/ET/ETJ/Log-Log4perl-1.53.tar.gz
    UPLOAD_DATE  2020-09-17
    MANPAGE      Log::Log4perl::Catalyst - Log::Log4perl Catalyst Module
    INST_FILE    /opt/perl-5.12.3/lib/site_perl/5.12.3/Log/Log4perl/Catalyst.pm
    INST_VERSION 1.49

Probably the reason is this line: https://metacpan.org/source/ETJ/Log-Log4perl-1.53/lib/Log/Log4perl/Catalyst.pm#L7 PAUSE looks only at the isolated $VERSION line when getting a module's version (for security reasons). It does not know anything about the Log::Log4perl module and the $VERSION value set there.

Possible fixes are:

mohawk2 commented 3 years ago

Set versions in that plus a couple of others, released as 1.54. Thanks!