search

mschilli / log4perl

Log4j Implementation For Perl
http://log4perl.com
Other
116 stars 66 forks source link

Log::Log4perl::Appender::File is using two args open #113

Open atoomic opened 2 years ago

atoomic commented 2 years ago

We should consider enforcing three args open in Log4perl

this is coming from sub file_open Log::Log4perl::Appender::File

     eval {
         if($self->{syswrite}) {
             sysopen $fh, "$self->{filename}", $sysmode or
                 die "Can't sysopen $self->{filename} ($!)";
         } else {
             open $fh, "$arrows$self->{filename}" or
                 die "Can't open $self->{filename} ($!)";
         }
     };
mohawk2 commented 2 years ago

Pull requests welcome!

atoomic commented 1 year ago

@mohawk2 just sent a PR with these changes