Closed xsawyerx closed 2 years ago
Adding another item: All warn
s and die
s should go to Log4perl. I can fix that before it's merged.
As discussed some minor fixup and improvements before we can merge this work Thanks a lot for providing support for v3
Updates:
auto_paging
option in helper method now documented.q
parameter is both define and has length.is_folder
method.
This is quite a big PR and might require additional conversation.
What is essentially done here is:
Simple.pm
was split toSimple/V2.pm
andCore.pm
.Core.pm
is a baseclass thatSimple/V2.pm
uses - all general methods moved there.Simple/V3.pm
is now introduced. It supports all the methods in V3. It uses some of what already exists and reinvents some.A few things to keep in mind:
get_*
methods might be better named as*
. For example,get_permission()
might be better aspermission()
- this is a bit tricky when some of them are verbs likereply()
orcomment()
.Item.pm
class which utilizesAUTOLOAD
.