search

mschilli / net-google-drive-simple

Net::Google::Drive::Simple CPAN Module
Other
11 stars 22 forks source link

More options for file uploads #8

Open martin67 opened 9 years ago

martin67 commented 9 years ago

Add possibility to set custom title and/or description of the uploaded file.

mschilli commented 9 years ago

Can you also add it to the POD docs, and provide an example so people know how to use it, please?

martin67 commented 9 years ago

Ok, I'll update that as well.

Regards //Martin

2014-11-20 9:17 GMT+01:00 Mike Schilli notifications@github.com:

Can you also add it to the POD docs, and provide an example so people know how to use it, please?

— Reply to this email directly or view it on GitHub https://github.com/mschilli/net-google-drive-simple/pull/8#issuecomment-63774312 .

atoomic commented 5 years ago

this looks good, but still need some POD update and basic usage so people can start using this feature. @martin67 are you still interested to add some doc/examples?

atoomic commented 4 years ago

@martin67 just checking if you are still interested adding the POD for this new feature? thanks

NetworkNed commented 4 years ago

With the addition of the rename method, the title option is scarcely necessary - I wouldn't have needed to write the rename method had this been available.

Using this code you can do:

  $drive_id = $gd->file_upload ( "/path/to/file" , $parent, $drive_id, "New Name" ) ;

The rename method was not available when @martin67 submitted this code, but now you can do the same thing with:

  $drive_id = $gd->file_upload ( "/path/to/file" , $parent, $drive_id ) ;
  $gd->rename (  $drive_id, "New Name" ) ;

I'd be inclined to add a $gd->description method rather than these options.

atoomic commented 4 years ago

@NetworkNed description method could be useful, feel free to submit a PR with it thanks

atoomic commented 3 years ago

Hi @NetworkNed I would like to know if you could rebase your branch and provide some POD for it? thanks

NetworkNed commented 3 years ago

This isn't my branch. Were you thinking of @martin67?

My contributions were completed with 514b2e8a5e309261f7516e735f2ffe24c2d91682 and 763baebca48532d95cf8917858d7036045bf18ca

With my comment above I intended to express that I think this pull request is obsolete and can be closed.

atoomic commented 3 years ago

oops sorry @NetworkNed I went too fast on it and was thinking you were the original author. You are right I was mainly asking @martin67 if he has any interest in rebasing this Pull Request with some docs?

atoomic commented 2 years ago

@martin67 I can notice that this PR was waiting for some extra work from your side Would you be interested in rebasing it and submitting it so we can get it in? thanks