search

mschlenstedt / LoxBerry-Plugin-Weather4Lox

A LoxBerry Plugin: http://plugins.loxberry.de/plugin/weather4lox/
Apache License 2.0
10 stars 10 forks source link

Weatherflow API bug workaround #75

Closed mr-manuel closed 1 year ago

mr-manuel commented 1 year ago

A bug caused the weather type to be 0, which caused other problems.

mschlenstedt commented 1 year ago

Hi,

so the bug was "cc-" in the API reply? What about the changes to the Weather code (formerly 15, now 18 for example)? Did we use the wrong codes in the past?

mschlenstedt commented 1 year ago

Ah, just read your comment here: https://github.com/mschlenstedt/LoxBerry-Plugin-Weather4Lox/issues/71

I understand ;-)

mschlenstedt commented 1 year ago

I will add another weather service (hopefully this weekend) and then release a new version with your changes. Thanks!

mr-manuel commented 1 year ago

Sorry, my initial pull request were only the first two changes, therefore the description. The other changes where made after the pull request, so I don‘t know how they landed here. Thanks

mschlenstedt commented 1 year ago

Yes, GitHub takes over all changes in your fork - rgardless when you made the PullRequest.

But if I understand correctly the changes to the weather code fix the problems in this issue https://github.com/mschlenstedt/LoxBerry-Plugin-Weather4Lox/issues/71

So I can also include them in the next release, correct?

mr-manuel commented 1 year ago

Yes and yes.