search

mschlenstedt / Loxberry

Current stable Branch is: *** Please see Releases *** Current developer Branch is: *** master ***
Apache License 2.0
75 stars 27 forks source link

Plugin installation link - allow query parameters after .zip #962

Closed VVlasy closed 5 years ago

VVlasy commented 5 years ago

I am working on an ebusd plugin and I use GitLab instead of GitHub. Before a recent update, I was able to install it from URL as well as update. See sample link below.

https://gitlab.com/VVlasy/loxberry-plugin-ebusd/-/jobs/227554799/artifacts/raw/loxberry-plugin-ebusd.zip?inline=false

The issue seems to be the query parameters ?inline=false Do you think it is possible to ignore query parameters in plugin link validation?

christianTF commented 5 years ago

https://github.com/mschlenstedt/Loxberry/commit/5df48bbe25e1a6aae7e19e0085c5bf05df03621c @Woersty

Woersty commented 5 years ago

Will have a look.

Woersty commented 5 years ago

@VVlasy please try the current "Latest Commit" version. http://loxberry/admin/system/updates.cgi

VVlasy commented 5 years ago

Works great! Thanks alot @Woersty !