search

mschneider / solcpp

A fast Solana and Mango Markets C++ SDK
Other
40 stars 13 forks source link

Code vuln scanning #21

Closed silas-x closed 2 years ago

silas-x commented 2 years ago

Hey Max

This PR adds cpp code vulnerability scanning to the existing test job. It adds a bit of overhead to the jobs, especially since the matrix of running the job for both linux and macos. Could consider separating to only run once. Depends a bit how much activity is expected on the main branch

Good news, no immediate issues!

mschneider commented 2 years ago

Yeah think separating this into it's own job is a good idea

silas-x commented 2 years ago

Included a condition to only run on the linux job. This is the fastest one and should cover all the tests.

mschneider commented 2 years ago

Sorry should have elaborated on this a bit more, I’m using the older Ubuntu version to guarantee compatibility with existing legacy systems. Was planning to extend to a larger build matrix eventually to also track the most recent version of compiler & os. Your scanner should always be run on the most recent version right?

silas-x commented 2 years ago

Ah, makes sense. Yeah, will refactor to make it completely separate. Was piggy-backing to reduce build time, but will just run in parallel anyway.