search

mschneider / solcpp

A fast Solana and Mango Markets C++ SDK
Other
40 stars 13 forks source link

Solana: port transaction submission API from web3.js #40

Closed mschneider closed 1 year ago

mschneider commented 1 year ago

requestAirdrop confirmTransaction sendEncodedTransaction sendRawTransaction sendTransaction simulateTransaction

aniketfuryrocks commented 1 year ago

Willing to work on this

Lioncat2002 commented 1 year ago

Willing to work on this as well

Lioncat2002 commented 1 year ago

@mschneider Added the requestAirdrop function I have two questions before I create a new PR

  1. How do I write a new test Since the hash that that gets returned by the rpc client changes everytime There isn't really anything that can be compared to check if the test passed.
  2. The rpc_url_ that you seem to be using in all the post request is set to the main net which doesn't have the requestAirdrop method So, should I set the post requestAirdrop url to devnet or testnet?
mschneider commented 1 year ago

requestAidrop should increase the sol balance of the wallet

mschneider commented 1 year ago

you can specify devnet url when creating the Connection object

mschneider commented 1 year ago

@Lioncat2002 @aniketfuryrocks

I noticed that the some of the new methods return json as response type. Please make sure you parse the json responses and created proper types for them, similar to what web3.js does. This will help users of the API to leverage type based auto completion to use the library more efficiently.

aniketfuryrocks commented 1 year ago