search

mschneider / solcpp

A fast Solana and Mango Markets C++ SDK
Other
39 stars 12 forks source link

Solana: Add confirmTransaction endpoint based on web3.js #44

Open aniketfuryrocks opened 1 year ago

aniketfuryrocks commented 1 year ago

Implement the feature confirmTransaction

Feature request moved from issue #40

mschneider commented 1 year ago

https://github.com/blockworks-foundation/mango-client-v3/blob/d34d248a3c9a97d51d977139f61cd982278b7f01/src/client.ts#L546

this is a working and well tested implementation for confirmTransaction in typescript the way this works:

a) define timeout, either by constant time (bad) or by optional BlockhashWithExpiryBlockHeight b) open a onSignature websocket connection - would leave this out for now and add it later when websockets are working c) poll every 2 seconds getSignatureStatuses - should work well enough for now

Lioncat2002 commented 1 year ago

Implementation based on c done. After testing, I will open a new PR once the current gets merged

mschneider commented 1 year ago

This issue is worked on in https://github.com/mschneider/solcpp/pull/58 given that @pSN0W is not ready yet, please try to implement a simplified version that uses a blockheight and signature status. Any timing based implementation won’t work reliably