search

mschout / perl-text-template

Expand template text with embedded Perl
13 stars 6 forks source link

Fix kwalitee issues #2

Closed kyzn closed 6 years ago

kyzn commented 6 years ago

Hi! Thanks for maintaining Text-Template. It was our CPAN-PRC assignment for the month, and we will be submitting a couple pull requests.

This one is for kwalitee score, which you can see at https://cpants.cpanauthors.org/dist/Text-Template

While @manwar's PR #1 handles use_strict and use_warnings, this commit here should handle experimental issues.

meta_yml_has_provides can be resolved by adding MetaProvides::Package, and build_prereq_matches_use can be resolved by adding Prereqs/BuildRequires.

Please let me know if you want me to update any part of this PR. Thanks!

cpan-prc #team-ziprecruiter #happy-holidays \o/

mschout commented 6 years ago

Not sure that Test::Pod should be a build prereq as thats only used if AUTHOR_TESTING=1, but really there's no harm.

Given that this issue is going to affect all of my modules which use my @MSCHOUT dzil plugin I will likely fix it there, and then simply doing a new release will take care of this.

Thanks for figuring this out!

kyzn commented 6 years ago

Thanks for your comment! In that case, I'm closing this PR. Have a great day!