search

mschubert / clustermq

R package to send function calls as jobs on LSF, SGE, Slurm, PBS/Torque, or each via SSH
https://mschubert.github.io/clustermq/
Apache License 2.0
146 stars 27 forks source link

Improved PBS Template + Docs of PBS / Torque Schedulers #185

Closed strazto closed 4 years ago

strazto commented 4 years ago

To resolve #184 Explicitly state that setting "PBS/Torque" as scheduler means a default template will be used, Fix typo in usage section Improve default PBS template, and template given in usage to submit array jobs

strazto commented 4 years ago

Hi @mschubert, I've made the changes you suggested, if you'd like to review this again

strazto commented 4 years ago

I have made the requested changes @mschubert .

Also, reading it back, I noticed that it was a bit confusing to see instructions on using a given scheduler with a customized template presented before the more simple instructions on allowing the scheduler to use the default template.

Particularly since setting options is persistent, so it feels weird to see instructions that rely on an option being unset to follow instructions where that option was explicitly set, since typically when we read a vignette, we treat most code blocks as if they "really" execute in order.

With that in mind, I restructured at the Torque and PBS sections.