(develop) torque/PBS- In worker cleanup, seems to be sending job names instead of PBS ids (Apparent regression of #186)

mschubert / clustermq

R package to send function calls as jobs on LSF, SGE, Slurm, PBS/Torque, or each via SSH

https://mschubert.github.io/clustermq/

Apache License 2.0

146 stars 27 forks source link

Closed strazto closed 1 year ago

strazto commented 3 years ago

This appears to be a regression of #186 in the develop branch. Not sure what's changed

qdel: illegally formed job identifier: cmq7547

strazto commented 3 years ago

Maybe #187 never properly fixed it? From what I can see, not much has changed

mschubert commented 3 years ago

Wasn't this your PR? :smile:

strazto commented 3 years ago

Wasn't this your PR? 😄

Yep! I swear it worked at the time, but somehow, for a reason that isn't clear to me, the job-name is being used for qdel instead of the id.

It could be a bug from some other change that somehow changed which QSys subclass is instantiated, but I haven't fully delved into it yet

mschubert commented 1 year ago

I think I fixed this now, if not please reopen