mschubert / ebits

R bioinformatics toolkit incubator
Apache License 2.0
6 stars 3 forks source link

plot module #35

Open mschubert opened 9 years ago

mschubert commented 9 years ago

Task list before merge into develop

Consider what's implemented in the ggfortify, GGally, ggdendro, ggRandomForests, and ggmcmc packages.

klmr commented 9 years ago

I’d like to avoid introducing inconsistencies if possible (don’t know what the status of this is). For instance, plotrix, heatmap.2 etc just do it objectively wrong.

We should try really, really hard to create APIs compatible with ggplot’s grammar of graphics, and with tidy data.

mschubert commented 9 years ago

We should try really, really hard to create APIs compatible with ggplot’s grammar of graphics, and with tidy data.

This is exactly what I'm trying to do.

However, there is things that ggplot2 can't easily do, like having the clustering tree next to the main plot. We'll have to find an acceptable solution for this. Options, as I see it, are (a) create an interface to pheatmap that takes the same structure as ggplot2 would and (b) teach ggplot2 about trees somehow.

klmr commented 9 years ago

There’s ggdendro. No idea how well that works. And I’ve just found plot_tree, which also looks interesting.

mschubert commented 9 years ago

ggally might also be something to look at

barzine commented 9 years ago

While you are working on this, can you also integer the options of heatmap3 (https://github.com/slzhao/heatmap3) for the annotation. Even, if I have to override some part of the function (and Nuno has also his own improved version) this package gives a nice overview of what I mean (http://www.biomedcentral.com/1471-2105/15/S10/P16/figure/F1) (I have a start of something myself, but I never come around to finish it yet)

jergosh commented 9 years ago

Greg Jordan wrote some ggplot-based code for plotting trees for Phylosim, if anyone feels like rolling their own and would like inspiration.

GregS

On Thu Feb 19 2015 at 10:08:32 AM M.P. Barzine notifications@github.com wrote:

While you are working on this, can you also integer the options of heatmap3 (https://github.com/slzhao/heatmap3) for the annotation. Even, if I have to override some part of the function (and Nuno has also his own improved version) this package gives a nice overview of what I mean ( http://www.biomedcentral.com/1471-2105/15/S10/P16/figure/F1)

— Reply to this email directly or view it on GitHub https://github.com/EBI-predocs/ebits/issues/35#issuecomment-75026426.