mschwartz / SilkJS

V8 Based JavaScript Swiss Army Knife (and HTTP Server!)
https://github.com/decafjs/decaf
Other
323 stars 37 forks source link

Issue trying to run make #23

Closed dorgan closed 12 years ago

dorgan commented 12 years ago

../src/objects.cc:7517:8: error: variable ‘proto_map’ set but not used [-Werror=unused-but-set-variable] cc1plus: all warnings being treated as errors make[3]: * [/home/dorgan/src/SilkJS/src/v8-read-only/out/ia32.release/obj.target/v8_base/src/objects.o] Error 1 make[3]: * Waiting for unfinished jobs.... make[3]: Leaving directory /home/dorgan/src/SilkJS/src/v8-read-only/out' make[2]: *** [ia32.release] Error 2 make[2]: Leaving directory/home/dorgan/src/SilkJS/src/v8-read-only' make[1]: * [v8-read-only/out/ia32.release/obj.target/tools/gyp/libv8_base.a] Error 2 make[1]: Leaving directory `/home/dorgan/src/SilkJS/src' make: * [all] Error 2

mschwartz commented 12 years ago

Yeah, this is a compile bug in the v8 code.

Edit v8-read-only/src/objects.cc

At line 7517 is a variable declared proto_map. A couple lines below it's assigned. It isn't used. Comment out both lines, it should make.

I also did a major redo of the install and make system.

You should be able to:

make make install

The first time you make install, it should set up permissions in /usr/local so everything can be installed in /usr/local/silkjs.

This means you can rm -rf /usr/share/silkjs

(but do it after you see the make works)

You have to git pull to see the changes.

On Jun 16, 2012, at 10:57 AM, dorgan wrote:

../src/objects.cc:7517:8: error: variable ‘proto_map’ set but not used [-Werror=unused-but-set-variable] cc1plus: all warnings being treated as errors make[3]: * [/home/dorgan/src/SilkJS/src/v8-read-only/out/ia32.release/obj.target/v8_base/src/objects.o] Error 1 make[3]: * Waiting for unfinished jobs.... make[3]: Leaving directory /home/dorgan/src/SilkJS/src/v8-read-only/out' make[2]: *** [ia32.release] Error 2 make[2]: Leaving directory/home/dorgan/src/SilkJS/src/v8-read-only' make[1]: * [v8-read-only/out/ia32.release/obj.target/tools/gyp/libv8_base.a] Error 2 make[1]: Leaving directory `/home/dorgan/src/SilkJS/src' make: * [all] Error 2


Reply to this email directly or view it on GitHub: https://github.com/mschwartz/SilkJS/issues/23

dorgan commented 12 years ago

I've installed SilkJS on multiple machines and am only just now having this issue. Why is it happening all of a sudden?

On Saturday, June 16, 2012, Michael Schwartz wrote:

Yeah, this is a compile bug in the v8 code.

Edit v8-read-only/src/objects.cc

At line 7517 is a variable declared proto_map. A couple lines below it's assigned. It isn't used. Comment out both lines, it should make.

I also did a major redo of the install and make system.

You should be able to:

make make install

The first time you make install, it should set up permissions in /usr/local so everything can be installed in /usr/local/silkjs.

This means you can rm -rf /usr/share/silkjs

(but do it after you see the make works)

You have to git pull to see the changes.

On Jun 16, 2012, at 10:57 AM, dorgan wrote:

../src/objects.cc:7517:8: error: variable ‘proto_map’ set but not used [-Werror=unused-but-set-variable] cc1plus: all warnings being treated as errors make[3]: * [/home/dorgan/src/SilkJS/src/v8-read-only/out/ia32.release/obj.target/v8_base/src/objects.o] Error 1 make[3]: * Waiting for unfinished jobs.... make[3]: Leaving directory `/home/dorgan/src/SilkJS/src/v8-read-only/out' make[2]: * [ia32.release] Error 2 make[2]: Leaving directory`/home/dorgan/src/SilkJS/src/v8-read-only' make[1]: * [v8-read-only/out/ia32.release/obj.target/tools/gyp/libv8_base.a] Error 2 make[1]: Leaving directory `/home/dorgan/src/SilkJS/src' make: *\ [all] Error 2


Reply to this email directly or view it on GitHub: https://github.com/mschwartz/SilkJS/issues/23


Reply to this email directly or view it on GitHub: https://github.com/mschwartz/SilkJS/issues/23#issuecomment-6376318

mschwartz commented 12 years ago

The v8 guys made a bad commit. They'll fix it. I reported it already.

On Jun 16, 2012, at 2:59 PM, dorgan wrote:

I've installed SilkJS on multiple machines and am only just now having this issue. Why is it happening all of a sudden?

On Saturday, June 16, 2012, Michael Schwartz wrote:

Yeah, this is a compile bug in the v8 code.

Edit v8-read-only/src/objects.cc

At line 7517 is a variable declared proto_map. A couple lines below it's assigned. It isn't used. Comment out both lines, it should make.

I also did a major redo of the install and make system.

You should be able to:

make make install

The first time you make install, it should set up permissions in /usr/local so everything can be installed in /usr/local/silkjs.

This means you can rm -rf /usr/share/silkjs

(but do it after you see the make works)

You have to git pull to see the changes.

On Jun 16, 2012, at 10:57 AM, dorgan wrote:

../src/objects.cc:7517:8: error: variable ‘proto_map’ set but not used [-Werror=unused-but-set-variable] cc1plus: all warnings being treated as errors make[3]: * [/home/dorgan/src/SilkJS/src/v8-read-only/out/ia32.release/obj.target/v8_base/src/objects.o] Error 1 make[3]: * Waiting for unfinished jobs.... make[3]: Leaving directory `/home/dorgan/src/SilkJS/src/v8-read-only/out' make[2]: * [ia32.release] Error 2 make[2]: Leaving directory`/home/dorgan/src/SilkJS/src/v8-read-only' make[1]: * [v8-read-only/out/ia32.release/obj.target/tools/gyp/libv8_base.a] Error 2 make[1]: Leaving directory `/home/dorgan/src/SilkJS/src' make: *\ [all] Error 2


Reply to this email directly or view it on GitHub: https://github.com/mschwartz/SilkJS/issues/23


Reply to this email directly or view it on GitHub: https://github.com/mschwartz/SilkJS/issues/23#issuecomment-6376318


Reply to this email directly or view it on GitHub: https://github.com/mschwartz/SilkJS/issues/23#issuecomment-6376795

dorgan commented 12 years ago

So you're pulling nightly? Wouldnt it make sense to just pull a specific version?

On Sat, Jun 16, 2012 at 7:15 PM, Michael Schwartz < reply@reply.github.com

wrote:

The v8 guys made a bad commit. They'll fix it. I reported it already.

On Jun 16, 2012, at 2:59 PM, dorgan wrote:

I've installed SilkJS on multiple machines and am only just now having this issue. Why is it happening all of a sudden?

On Saturday, June 16, 2012, Michael Schwartz wrote:

Yeah, this is a compile bug in the v8 code.

Edit v8-read-only/src/objects.cc

At line 7517 is a variable declared proto_map. A couple lines below it's assigned. It isn't used. Comment out both lines, it should make.

I also did a major redo of the install and make system.

You should be able to:

make make install

The first time you make install, it should set up permissions in /usr/local so everything can be installed in /usr/local/silkjs.

This means you can rm -rf /usr/share/silkjs

(but do it after you see the make works)

You have to git pull to see the changes.

On Jun 16, 2012, at 10:57 AM, dorgan wrote:

../src/objects.cc:7517:8: error: variable ‘proto_map’ set but not used [-Werror=unused-but-set-variable] cc1plus: all warnings being treated as errors make[3]: ***

[/home/dorgan/src/SilkJS/src/v8-read-only/out/ia32.release/obj.target/v8_base/src/objects.o] Error 1

make[3]: * Waiting for unfinished jobs.... make[3]: Leaving directory /home/dorgan/src/SilkJS/src/v8-read-only/out' make[2]: *** [ia32.release] Error 2 make[2]: Leaving directory/home/dorgan/src/SilkJS/src/v8-read-only' make[1]: * [v8-read-only/out/ia32.release/obj.target/tools/gyp/libv8_base.a] Error 2 make[1]: Leaving directory `/home/dorgan/src/SilkJS/src' make: *\ [all] Error 2


Reply to this email directly or view it on GitHub: https://github.com/mschwartz/SilkJS/issues/23


Reply to this email directly or view it on GitHub: https://github.com/mschwartz/SilkJS/issues/23#issuecomment-6376318


Reply to this email directly or view it on GitHub: https://github.com/mschwartz/SilkJS/issues/23#issuecomment-6376795


Reply to this email directly or view it on GitHub: https://github.com/mschwartz/SilkJS/issues/23#issuecomment-6377325

dorgan commented 12 years ago

OK i've made the two change and tried running make once again, now I am getting:

make[3]: * [/home/dorgan/src/SilkJS/src/v8-read-only/out/ia32.release/obj.target/v8_base/src/objects.o] Error 1 make[3]: * Waiting for unfinished jobs.... make[3]: Leaving directory /home/dorgan/src/SilkJS/src/v8-read-only/out' make[2]: *** [ia32.release] Error 2 make[2]: Leaving directory/home/dorgan/src/SilkJS/src/v8-read-only' make[1]: * [v8-read-only/out/ia32.release/obj.target/tools/gyp/libv8_base.a] Error 2 make[1]: Leaving directory `/home/dorgan/src/SilkJS/src' make: * [all] Error 2

dorgan commented 12 years ago

OK never mind, used the wrong comment syntax.