search

mschwarzmueller / nextjs-complete-guide-course-resources

Course resources for my "NextJS - The Complete Guide" course (https://acad.link/nextjs)
346 stars 238 forks source link

Small bug with preview image #1

Open martinbel opened 4 months ago

martinbel commented 4 months ago

Hi @maxschwarzmueller, I think there is part of the css code missing from this lecture: https://github.com/mschwarzmueller/nextjs-complete-guide-course-resources/blob/main/code/02-nextjs-essentials/23-adding-an-image-preview/components/meals/image-picker.module.css

There are 2 issues:

  1. The is not hidden.
  2. The image is not getting scaled when doing the preview.

I'm copy/pasting the exact code and following the lectures, but could be missing something.

great course! BTW

GDevWeb commented 1 month ago

Hello, thank you so much for your courses. I’ve learned so much from them! I had almost no issues with your code, except when it came to using the

element. I’m using the modal from react-dom, maybe because my browser doesn’t support it—I haven’t dug into it yet... At first, I was a bit worried because you're an English speaker and I’m a French guy with somewhat rusty English. But I turned on the English subtitles and reviewed them while following your courses. I’ve never found the same quality in French courses on Udemy. You’re awesome! 👍