search

mse150s20 / p2-kinetics

1 stars 22 forks source link

Pull request test #19

Closed sampiraino closed 4 years ago

sampiraino commented 4 years ago

Nothing really to add

jennyfothergill commented 4 years ago

@sampiraino, your change to kinetics.py will not run in python (line 20). Please fix before I can merge.

sampiraino commented 4 years ago

Okay, I believe I was able to return to original

On Mon, Apr 6, 2020 at 11:23 AM jennyfothergill notifications@github.com wrote:

@sampiraino https://github.com/sampiraino, your change to kinetics.py will not run in python (line 20). Please fix before I can merge.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mse150s20/p2-kinetics/pull/19#issuecomment-609928009, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOY4KZDB2VG5T5GNYFAPJE3RLIFX3ANCNFSM4MCOJ6CA .

jennyfothergill commented 4 years ago

I like it! I just commented on your issue before looking at this, so I'm happy to see you figured out pandas on your own! Let's rename finding to finding.py to let people know that it's a python script and add the source for the data to the readme, otherwise this looks great! You can add a link in markdown like this [link text](url) You can tell git to rename a file like this git mv oldfilename newfilename

sampiraino commented 4 years ago

Okay, I've updated changes. I link just added the link hashtagged in the links section of README