search

mseaberg / Commissioning_Tools

0 stars 0 forks source link

Integrate legacy hard x-ray imagers #77

Open mseaberg opened 2 years ago

mseaberg commented 2 years ago

There are some issues related to integrating the legacy imagers.

  1. PV naming convention is different, and also the pcdsdevices device types are generally different. It might help to make more use of the pcdsdevices classes.
  2. For inserting and removing the imagers, the way states are handled seems different. Might be able to mostly take care of this by having two versions of the ImagerControls widget.
mseaberg commented 2 years ago

The right approach is probably to copy both this repository and the lcls_beamline_toolbox repository and make this work somewhere where it doesn't interfere with soft X-ray operations. Can make a new directory in my home directory, called HXR_Trajectory.

mseaberg commented 2 years ago

Cloned the two repositories into that directory, and created new branches for both called "hxr". Should be able to safely mess around here without affecting any operations.

mseaberg commented 2 years ago

One possibility is to use happi as in the following. This would likely be the easiest way to access relevant motors, etc. But there is potentially some loading time involved and not sure how lightweight this solution is (maybe doesn't matter). This will provide the corresponding pcdsdevices object.

In [1]: import happi

In [2]: client = happi.Client(path="/reg/g/pcds/pyps/apps/hutch-python/device_config/db.json")

In [3]: imager = client.load_device(name="im3k4")